added solution #1198
Open
added solution #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okuzan
suggested changes
Oct 11, 2023
There was a problem hiding this comment.
Hey there! 😊 Before you submit your work for review, please go through the checklist under the task and make any necessary corrections. 📝✅ Your mentor will be happy to help once those points are sorted out. Don't worry, it's all part of the learning process! 📚✨
Sanderfuck
suggested changes
Nov 28, 2023
Comment on lines
+7
to
+12
| Ball ball = lottery.getRandomBall(); | ||
| Ball ball1 = lottery.getRandomBall(); | ||
| Ball ball2 = lottery.getRandomBall(); | ||
| System.out.println(ball); | ||
| System.out.println(ball1); | ||
| System.out.println(ball2); |
Comment on lines
+7
to
+21
| public String getColor() { | ||
| return color; | ||
| } | ||
|
|
||
| public void setColor(String color) { | ||
| this.color = color; | ||
| } | ||
|
|
||
| public int getNumber() { | ||
| return number; | ||
| } | ||
|
|
||
| public void setNumber(int number) { | ||
| this.number = number; | ||
| } |
| return null; | ||
|
|
||
| public Colors getRandomColor() { | ||
| int index = new Random().nextInt(Colors.values().length); |
There was a problem hiding this comment.
You need only one Random object and you can create it field of class
| } | ||
|
|
||
| public int getRandomNumber() { | ||
| return new Random().nextInt(100); |
Comment on lines
+6
to
+13
| public Ball getRandomBall() { | ||
| ColorSupplier colorSupplier = new ColorSupplier(); | ||
| String color1 = colorSupplier.getRandomColor().toString(); | ||
| int number1 = getRandomNumber(); | ||
| Ball ball = new Ball(); | ||
| ball.setColor(color1); | ||
| ball.setNumber(number1); | ||
| return ball; |
kozhukhovsky
approved these changes
Dec 21, 2023
Comment on lines
+7
to
+12
| Ball ball = lottery.getRandomBall(); | ||
| Ball ball1 = lottery.getRandomBall(); | ||
| Ball ball2 = lottery.getRandomBall(); | ||
| System.out.println(ball); | ||
| System.out.println(ball1); | ||
| System.out.println(ball2); |
| return null; | ||
|
|
||
| public Colors getRandomColor() { | ||
| int index = new Random().nextInt(Colors.values().length); |
Comment on lines
+6
to
+13
| public Ball getRandomBall() { | ||
| ColorSupplier colorSupplier = new ColorSupplier(); | ||
| String color1 = colorSupplier.getRandomColor().toString(); | ||
| int number1 = getRandomNumber(); | ||
| Ball ball = new Ball(); | ||
| ball.setColor(color1); | ||
| ball.setNumber(number1); | ||
| return ball; |
| } | ||
|
|
||
| public int getRandomNumber() { | ||
| return new Random().nextInt(100); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.