Create a simple lottery #1276
Open
Create a simple lottery #1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olekskov
suggested changes
Dec 9, 2023
Sanderfuck
suggested changes
Dec 11, 2023
Comment on lines
7
to
21
| public String getColor() { | ||
| return color; | ||
| } | ||
|
|
||
| public void setColor(String color) { | ||
| this.color = color; | ||
| } | ||
|
|
||
| public Integer getNumber() { | ||
| return number; | ||
| } | ||
|
|
||
| public void setNumber(Integer number) { | ||
| this.number = number; | ||
| } |
There was a problem hiding this comment.
Better use constructor for init Ball object
| public class ColorSupplier { | ||
| public String getRandomColor() { | ||
| return null; | ||
| int inedex = new Random().nextInt(Colors.values().length); |
Comment on lines
4
to
10
| Red, | ||
| Blue, | ||
| Yellow, | ||
| White, | ||
| Green, | ||
| Orange, | ||
| Violet |
Comment on lines
8
to
10
| Random random = new Random(); | ||
| ball.setNumber(random.nextInt(100)); | ||
| ColorSupplier supplier = new ColorSupplier(); |
| Random random = new Random(); | ||
| ball.setNumber(random.nextInt(100)); | ||
| ColorSupplier supplier = new ColorSupplier(); | ||
| ball.setColor(supplier.getRandomColor()); |
Sanderfuck
suggested changes
Dec 12, 2023
| public class ColorSupplier { | ||
| public String getRandomColor() { | ||
| return null; | ||
| Random random = new Random(); |
There was a problem hiding this comment.
Create Random in field of class, cause every invoke of method create new object!
Comment on lines
7
to
8
| Random random = new Random(); | ||
| ColorSupplier supplier = new ColorSupplier(); |
| public Ball getRandomBall() { | ||
| Random random = new Random(); | ||
| ColorSupplier supplier = new ColorSupplier(); | ||
| int randomNumber = random.nextInt(100); |
There was a problem hiding this comment.
Magic number 100, what about constant?
okuzan
suggested changes
Jan 5, 2024
Comment on lines
9
to
10
| int inedex = random.nextInt(Colors.values().length); | ||
| return Colors.values()[inedex].toString(); |
There was a problem hiding this comment.
index misspelled, don't use toString - revisit checklist, this issue is mentioned there
| @@ -0,0 +1,11 @@ | |||
| package core.basesyntax; | |||
|
|
|||
| public enum Colors { | |||
There was a problem hiding this comment.
Suggested change
| public enum Colors { | |
| public enum Color { |
enum should be in singular
| public class Lottery { | ||
| private Random random = new Random(); | ||
| private ColorSupplier supplier = new ColorSupplier(); | ||
| private int maxNumber = 100; |
There was a problem hiding this comment.
make it constant - static final + MAX_NUMBER, and change to 101, because the value passed to randomizer is excluded itself
| public Ball getRandomBall() { | ||
| int randomNumber = random.nextInt(maxNumber); | ||
| String randomColor = supplier.getRandomColor(); | ||
| return new Ball(randomColor,randomNumber); |
There was a problem hiding this comment.
we need space after comma, format your files in IDEA before committing (Ctrl Alt L)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.