-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lottery task to check #1763
base: master
Are you sure you want to change the base?
Lottery task to check #1763
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on implementing the task requirements! 🎉 Your code is functional and meets the core requirements. While there are minor suggestions for improvement, such as removing an unnecessary import and using a loop for creating multiple Ball
instances, these do not impact the functionality. Keep up the good work and consider these suggestions for cleaner and more maintainable code in the future! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
Ball ball1 = lottery.getRandomBall(); | ||
Ball ball2 = lottery.getRandomBall(); | ||
Ball ball3 = lottery.getRandomBall(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a loop to create multiple Ball
instances. According to the checklist, using a loop is a better practice when creating several objects of the same class. This will make your code more concise and maintainable .
@@ -1,7 +1,14 @@ | |||
package core.basesyntax; | |||
|
|||
import java.util.Random; | |||
import java.util.concurrent.Callable; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The import statement for Callable
is unnecessary and can be removed since it is not used in this class.
No description provided.