jv-lottery-solution #1765
jv-lottery-solution #1765
Conversation
There was a problem hiding this comment.
Thank you for your hard work on this project! There are a few critical issues that need to be addressed before we can approve the pull request. The most important ones are:
-
Enum Naming Convention: The enum
colorshould be renamed toColorto adhere to Java naming conventions. This is crucial for maintaining consistency and readability in your code. -
Static Method Usage: The
getRandomColor()method inColorSupplieris currently static, which goes against the checklist requirements. It's recommended to use an instance method instead, which will improve the design and flexibility of your code.
These changes are necessary to ensure that the code meets the core requirements and functions as expected. Once these issues are resolved, your code will be in great shape! Keep up the great work, and don't hesitate to reach out if you have any questions or need further assistance. 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
| public class ColorSupplier { | ||
| public String getRandomColor() { | ||
| return null; | ||
| public static color getRandomColor() { |
There was a problem hiding this comment.
The return type color should be capitalized to Color to match Java naming conventions for enums. Ensure the enum is defined as Color in your project.
| public class ColorSupplier { | ||
| public String getRandomColor() { | ||
| return null; | ||
| public static color getRandomColor() { |
There was a problem hiding this comment.
Avoid using static methods as per the checklist. Consider creating an instance of ColorSupplier and using an instance method instead.
| public class Lottery { | ||
| private static final Random RANDOM = new Random(); | ||
| public Ball getRandomBall() { | ||
| color randomColor = ColorSupplier.getRandomColor(); |
There was a problem hiding this comment.
The type color should be capitalized to Color to match Java naming conventions for enums. Ensure the enum is defined as Color in your project.
| public class Lottery { | ||
| private static final Random RANDOM = new Random(); | ||
| public Ball getRandomBall() { | ||
| color randomColor = ColorSupplier.getRandomColor(); |
There was a problem hiding this comment.
Avoid using static methods as per the checklist. Consider creating an instance of ColorSupplier and using an instance method instead.
| @@ -0,0 +1,6 @@ | |||
| package core.basesyntax; | |||
|
|
|||
| public enum color { RED, BLUE, GREEN, YELLOW, ORANGE, PURPLE, WHITE, BLACK; | |||
There was a problem hiding this comment.
Rename the enum color to Color to follow Java naming conventions for types, which use PascalCase.
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: 7]
If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.
There was a problem hiding this comment.
Great job on addressing the previous issues! 🎉 Your code now adheres to the task requirements and constraints. The Application, Ball, Color, ColorSupplier, and Lottery classes are all well-implemented. The Color enum follows Java naming conventions, and the ColorSupplier class correctly uses an instance method for getRandomColor().
While the code is approved, ensure that the Lottery class and its getRandomBall() method are implemented correctly to avoid runtime errors. Also, double-check that the Ball constructor accepts a String for the color.
Keep up the good work, and remember to review the comments to improve your code further. Address any critical issues in future projects to enhance your coding skills. Keep learning and growing! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
No description provided.