Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial commit #1618

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

initial commit #1618

wants to merge 1 commit into from

Conversation

arhip14
Copy link

@arhip14 arhip14 commented Jan 29, 2025

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the WorkWithFile class! 🎉 Your code meets the core requirements and functions as expected. While there are some areas for improvement, such as method length and use of constants, these are minor and don't impact the overall functionality. Keep up the good work, and consider the feedback for future enhancements to make your code even better! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

String operation = parts[0].trim();
int amount = Integer.parseInt(parts[1].trim());

if (operation.equals("supply")) { // Виправлено назву

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment '// Виправлено назву' is not necessary for the functionality of the code. Consider removing it if it's not needed for documentation purposes.

throw new RuntimeException("Error reading file", e);
}

int result = supplySum - buySum;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the calculation of result (supplySum - buySum) aligns with the task requirements. If the task specifies a different calculation, adjust accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants