Solution #1141
Open
Solution #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdAlekseiev
suggested changes
Dec 25, 2023
app/main.py
Outdated
Comment on lines
21
to
32
| q1 = {"lucky_number": lucky_number, "lucky_number": lucky_number, | ||
| "one_is_a_prime_number": one_is_a_prime_number, | ||
| "name": name, "my_favourite_films": my_favourite_films, | ||
| "profile_info": profile_info, "marks": marks, | ||
| "collection_of_coins": collection_of_coins, | ||
| "sorted_variables": sorted_variables} | ||
|
|
||
| for i in q1: | ||
| if type(q1[i]) == int or type(q1[i]) == str or type(q1[i]) == bool or type(q1[i]) == float or type(q1[i]) == tuple: | ||
| sorted_variables["immutable"].append(i) | ||
| else: | ||
| sorted_variables["mutable"].append(i) |
There was a problem hiding this comment.
You can explicitly create dictionary with defined keys and values. for loop is unnecessary for this specific task.
app/main.py
Outdated
| @@ -1,5 +1,5 @@ | |||
| lucky_number = 777 | |||
| pi = 3.14 | |||
| lucky_number = 3.14 | |||
EdAlekseiev
suggested changes
Jan 2, 2024
app/main.py
Outdated
Comment on lines
18
to
26
| a_ = my_favourite_films | ||
| b_ = marks | ||
| c_ = collection_of_coins | ||
| d_ = lucky_number | ||
| e_ = one_is_a_prime_number | ||
| r_ = pi | ||
| t_ = name | ||
| y_ = profile_info | ||
| sorted_variables = {"mutable": [a_, b_, c_], "immutable": [d_, e_, r_, t_, y_]} |
There was a problem hiding this comment.
Suggested change
| a_ = my_favourite_films | |
| b_ = marks | |
| c_ = collection_of_coins | |
| d_ = lucky_number | |
| e_ = one_is_a_prime_number | |
| r_ = pi | |
| t_ = name | |
| y_ = profile_info | |
| sorted_variables = {"mutable": [a_, b_, c_], "immutable": [d_, e_, r_, t_, y_]} | |
| sorted_variables = { | |
| "mutable": [my_favourite_films, marks, collection_of_coins], | |
| "immutable": [lucky_number, pi, one_is_a_prime_number, name, profile_info] | |
| } |
NikOneZ1
suggested changes
Jan 2, 2024
EdAlekseiev
suggested changes
Jan 2, 2024
app/main.py
Outdated
Comment on lines
18
to
26
| a_ = my_favourite_films | ||
| b_ = marks | ||
| c_ = collection_of_coins | ||
| d_ = lucky_number | ||
| e_ = one_is_a_prime_number | ||
| r_ = pi | ||
| t_ = name | ||
| y_ = profile_info | ||
| sorted_variables = {"mutable": [a_, b_, c_], "immutable": [d_, e_, r_, t_, y_]} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.