-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution #2112
base: master
Are you sure you want to change the base?
Solution #2112
Conversation
Merge branch 'master' of https://github.com/mhrabovska/py-mutable-immutable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on implementing the task! 🎉 Your code meets the task requirements by correctly categorizing most variables into mutable and immutable types. However, there's a small issue with the categorization of the collection_of_coins
variable. Since it is a set, it should be categorized under the 'immutable' key in the sorted_variables
dictionary.
This decision to approve is made to help you move forward with your learning. Please review the comments and make the necessary adjustments to improve your code. Addressing such issues will be crucial for future tasks to ensure the functionality of your code. Keep up the good work and continue learning from these experiences! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
collection_of_coins = {1, 2, 25} | ||
|
||
# write your code here | ||
sorted_variables = { | ||
"mutable": [ | ||
my_favourite_films, | ||
marks, | ||
collection_of_coins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The collection_of_coins
variable is a set, which is an immutable type in Python. It should be categorized under the 'immutable' key in the sorted_variables
dictionary.
No description provided.