Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit #2126

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Commit #2126

wants to merge 1 commit into from

Conversation

Volodymyrdv
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on categorizing the variables into mutable and immutable types! 🎉 While the collection_of_coins is indeed a set and should be classified as immutable, this is a minor issue that doesn't significantly impact the functionality of your code. Keep up the great work, and consider making this small adjustment for even more accuracy in the future! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +19 to +22
sorted_variables = {
"mutable": [my_favourite_films, marks, collection_of_coins],
"immutable": [lucky_number, pi, one_is_a_prime_number, name, profile_info]
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The collection_of_coins variable is a set, which is an immutable type in Python. However, it is currently categorized under 'mutable' in the sorted_variables dictionary. Consider moving it to the 'immutable' category.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants