Skip to content

Commit

Permalink
remove unused import
Browse files Browse the repository at this point in the history
  • Loading branch information
@guidezpl
guidezpl committed Feb 6, 2024
1 parent 2cf7384 commit e32cc8e
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
2 changes: 0 additions & 2 deletions packages/google_fonts/lib/src/google_fonts_base.dart
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import 'dart:ui';

import 'package:crypto/crypto.dart';
import 'package:flutter/material.dart';
// TODO(andrewkolos): The flutter framework wishes to add a new class named
Expand Down
2 changes: 0 additions & 2 deletions packages/google_fonts/test/generated_font_methods_test.dart
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import 'dart:ui';

import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:google_fonts/google_fonts.dart';
Expand Down

4 comments on commit e32cc8e

@elmobark
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your commit breaks the package

@bypass112
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be reverted

https://stackoverflow.com/questions/78090711/error-type-fontfeature-not-found-flutter-google-fonts-package-error

@carlos-alex
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing Import for dart:ui in google_fonts_base.dart

Description:
I'm encountering an error when using the google_fonts package, specifically version 6.2.0. The error is related to the missing FontFeature type. It appears that the import for dart:ui is missing in the google_fonts_base.dart file.

Error Message:

AppData/Local/Pub/Cache/hosted/pub.dev/google_fonts-6.2.0/lib/src/google_fonts_base.dart:69:8: Error: Type 'FontFeature' not found.
List? fontFeatures,
^^^^^^^^^^^
AppData/Local/Pub/Cache/hosted/pub.dev/google_fonts-6.2.0/lib/src/google_fonts_base.dart:69:8: Error: 'FontFeature' isn't a type.
List? fontFeatures,
^^^^^^^^^^^
Suggested Fix:
Please add the following import statement to the google_fonts_base.dart file to resolve this issue:

import 'dart:ui';
This should be added at the top of the file to ensure that the FontFeature type is recognized.

Thank you!

@guidezpl
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replied in #600

Please sign in to comment.