Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(toast): property to specify an element as toast content instead … #2

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

danice
Copy link
Contributor

@danice danice commented Nov 21, 2023

Proposed changes

Documentation update corresponding to materializecss/materialize#436

Alternative solution to "[Bug]: Toast html/unsafeHtml not work #394 ". This will allow to specify some element as tooltip content. A new property data-tooltip-id will allow specify an element as tooltip content instead of text.

Screenshots (if appropriate) or codepen:

will appear as (this also shows part of corresponding update in docs)

imagen

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • [ x I have read the CONTRIBUTING document.
  • My commit messages follows the conventional commit format
  • My change requires a change to the documentation, and updated it accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Contributor Author

@danice danice Nov 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only real change is in toast.ts file.

All the other files appears because previous materializecss submodule was in "Merge pull request #434 from materializecss/release-2.0.3-beta" commit, and I have done the this from "Merge pull request #435 from danice/fix". Maybe we should first do the merge of materializacss changes to this materializecss main and then do the PR in docs...

imagen

@wuda-io wuda-io changed the base branch from main to v2-dev December 14, 2023 22:35
@wuda-io wuda-io merged commit 64962bc into materializecss:v2-dev Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants