Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datepicker): Date picker didnot change calendar when selecting month or year from dropdown #429

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

abhigyanghosh30
Copy link

@abhigyanghosh30 abhigyanghosh30 commented Oct 16, 2023

Proposed changes

When you select a different month or year in the date picker dropdown, it does not actually change the calendar to that month or year. This PR fixes that bug. Issue #412

Screenshots (if appropriate) or codepen:

Original: https://jsfiddle.net/SeCrEt_BoY/m50y8Lq3/8/
After Fix: https://jsfiddle.net/abhigyanghosh30/odushvaz/32/

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My commit messages follows the conventional commit format
  • My change requires a change to the documentation, and updated it accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@abhigyanghosh30 abhigyanghosh30 changed the base branch from main to v2-dev October 16, 2023 14:30
@wuda-io
Copy link
Member

wuda-io commented Oct 19, 2023

Awesome, looks good to me! Thank you for your work, let's merge it in 👍
I send you an invitation to the team. Would be cool if we bring this project forward.
Best greetings.

@wuda-io wuda-io merged commit aee5d8e into materializecss:v2-dev Oct 19, 2023
2 checks passed
@abhigyanghosh30
Copy link
Author

Awesome, looks good to me! Thank you for your work, let's merge it in 👍 I send you an invitation to the team. Would be cool if we bring this project forward. Best greetings.

Thanks! Would love to meet the team.

@phil-l-brockwell
Copy link

phil-l-brockwell commented Oct 24, 2023

Hi guys, any idea when you will roll this out?

@Jerit3787
Copy link

Hi guys, any idea when you will roll this out?

This will take a while. If you need urgently, you can always download the build from CI.

https://github.com/materializecss/materialize/suites/17278807484/artifacts/995887051

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants