Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: #500 Flag for the ScrollSpy component that ensures the last active element remains visible + animationDuration option #504

Merged
merged 6 commits into from
Nov 26, 2024

Conversation

IvanPostu
Copy link
Member

@IvanPostu IvanPostu commented Sep 8, 2024

fixes #500

Proposed changes

Screenshots (if appropriate) or codepen:

Demo Video

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My commit messages follows the conventional commit format
  • My change requires a change to the documentation, and updated it accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@IvanPostu IvanPostu self-assigned this Sep 8, 2024
@IvanPostu IvanPostu requested a review from wuda-io September 8, 2024 17:00
@wuda-io
Copy link
Member

wuda-io commented Sep 9, 2024

Nice, your video explaines it very clearly 👍 i will review the code tomorrow.

src/scrollspy.ts Outdated Show resolved Hide resolved
@IvanPostu IvanPostu changed the title enhancement: #500 Flag for the ScrollSpy component that ensures the last active element remains visible enhancement: #500 Flag for the ScrollSpy component that ensures the last active element remains visible + animationDuration option Sep 11, 2024
@wuda-io wuda-io changed the base branch from main to v2-dev November 13, 2024 11:42
@wuda-io
Copy link
Member

wuda-io commented Nov 13, 2024

Please use more descriptive commit messages.
Also apply commit lint format so we can properly generate the changelog.
https://commitlint.io

@wuda-io wuda-io merged commit ecb57d3 into materializecss:v2-dev Nov 26, 2024
1 check failed
@wuda-io
Copy link
Member

wuda-io commented Nov 26, 2024

Could you please also update the docs?
Please make a PR here https://github.com/materializecss/materialize-docs
Make sure you use the dev branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flag for the ScrollSpy component that ensures the last active element remains visible
2 participants