Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timepicker accessibility #531

Merged

Conversation

gselderslaghs
Copy link
Member

Proposed changes

This PR fixes issue as described in this comment in #476
Additional styling improvements have been applied as described in the Material guidelines, this applies mainly to margins/paddings, the addition of a button class to the am/pm buttons and usage of button-filled state instead of applying text-primary class on am/pm select

Screenshots (if appropriate) or codepen:

Before
Screenshot 2024-11-14 at 14 36 40
Screenshot 2024-11-14 at 14 32 21

After
Screenshot 2024-11-17 at 22 49 15
Screenshot 2024-11-17 at 22 49 00

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My commit messages follows the conventional commit format
  • My change requires a change to the documentation, and updated it accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gselderslaghs gselderslaghs changed the base branch from main to v2-dev November 17, 2024 21:52
Copy link
Member

@wuda-io wuda-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wuda-io wuda-io merged commit cefdbf8 into materializecss:v2-dev Nov 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants