Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accessibility(Cards) refactored component based, implemented tab index and aria expanded #555

Merged
merged 2 commits into from
Dec 21, 2024

Conversation

gselderslaghs
Copy link
Member

@gselderslaghs gselderslaghs commented Dec 15, 2024

Proposed changes

Cards accessibility #539
Refactored the Cards component component based in an object orientated manner
Implemented tab index and aria expanded to enhance accessibility

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My commit messages follows the conventional commit format
  • My change requires a change to the documentation, and updated it accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@wuda-io wuda-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. I think this also needs a documentation update.

@gselderslaghs
Copy link
Member Author

Awesome. I think this also needs a documentation update.

Updated the docs accordingly

@wuda-io wuda-io merged commit c24f233 into materializecss:v2-dev Dec 21, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants