Skip to content

Commit

Permalink
Add TODO
Browse files Browse the repository at this point in the history
  • Loading branch information
munrojm committed Jul 18, 2024
1 parent 1eb19ba commit 631567f
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions mp_api/client/mprester.py
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,8 @@ def __init__(
elif "molecules" in suffix_split:
_sub_rester_suffix_map["molecules"][attr] = cls

# TODO: Enable monty decoding when tasks and SNL schema is normalized
#
# Allow lazy loading of nested resters under materials and molecules using custom __getattr__ methods
def __core_custom_getattr(_self, _attr, _rester_map):
if _attr in _rester_map:
Expand Down Expand Up @@ -949,9 +951,7 @@ def get_ion_reference_data(self) -> list[dict]:
query={"project": "ion_ref_data"},
fields=["identifier", "formula", "data"],
paginate=True,
).get(
"data"
) # type: ignore
).get("data") # type: ignore

def get_ion_reference_data_for_chemsys(self, chemsys: str | list) -> list[dict]:
"""Download aqueous ion reference data used in the construction of Pourbaix diagrams.
Expand Down Expand Up @@ -1230,8 +1230,10 @@ def get_bandstructure_by_material_id(
Returns:
bandstructure (Union[BandStructure, BandStructureSymmLine]): BandStructure or BandStructureSymmLine object
"""
return self.electronic_structure_bandstructure.get_bandstructure_from_material_id( # type: ignore
material_id=material_id, path_type=path_type, line_mode=line_mode
return (
self.electronic_structure_bandstructure.get_bandstructure_from_material_id( # type: ignore
material_id=material_id, path_type=path_type, line_mode=line_mode
)
)

def get_dos_by_material_id(self, material_id: str):
Expand Down

0 comments on commit 631567f

Please sign in to comment.