Simpler molecule graph support + performance enhancement to XRD plot #334
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
This PR implements two completely separate features:
For feature 1, I had implemented this locally before MoleculeGraph support was added. I think my implementation was a bit cleaner so I propose replacing the current one.
For feature 2, I had implemented this vectorization in mp-web for the IRSpectra. @mattmcdermott suggested I push upstream. This is not an exact port of my code in the IRSpectra, so it's possible there are bugs. I don't have a good testing env set up, so it should be tested before being merged. I probably won't have time to clean this up further but I definitely think it's worth doing!
Checklist
Work-in-progress pull requests are encouraged but please mark your PR as draft.
Usually, the following items should be checked before merging a PR:
mypy path/to/file.py
to type-check your code. Type checks are run in CI.