Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simpler molecule graph support + performance enhancement to XRD plot #334

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

orionarcher
Copy link
Contributor

Features

This PR implements two completely separate features:

  1. It cleans up the support for MoleculeGraphs in structure.py
  2. It vectorizes the XRD implementation to improve performance 30x

For feature 1, I had implemented this locally before MoleculeGraph support was added. I think my implementation was a bit cleaner so I propose replacing the current one.

For feature 2, I had implemented this vectorization in mp-web for the IRSpectra. @mattmcdermott suggested I push upstream. This is not an exact port of my code in the IRSpectra, so it's possible there are bugs. I don't have a good testing env set up, so it should be tested before being merged. I probably won't have time to clean this up further but I definitely think it's worth doing!

Checklist

Work-in-progress pull requests are encouraged but please mark your PR as draft.

Usually, the following items should be checked before merging a PR:

  • Doc strings have been added in the Google docstring format.
  • Type annotations are highly encouraged. Run mypy path/to/file.py to type-check your code. Type checks are run in CI.
  • Tests for any new functionality as well as bug fixes, where appropriate.
  • Create a new Issue for any TODO items that will result from merging the PR.

@orionarcher
Copy link
Contributor Author

orionarcher commented May 5, 2023

Hey @yang-ruoxi. This is a 30x performance improvement over the current implementation but I won't have any time to test it further. I do think it's worth finalizing the implementation if you have the bandwidth! Happy to chat more.

@yang-ruoxi
Copy link
Member

thanks @orionarcher ! this is very nice. I will test it soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants