Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NEB schemas #1123

Open
wants to merge 27 commits into
base: main
Choose a base branch
from

Conversation

esoteric-ephemera
Copy link
Collaborator

@esoteric-ephemera esoteric-ephemera commented Oct 4, 2024

Adding support for parsing NEB calculations and eventually ApproxNEB calculations. These are still VASP calculations, but have a directory structure which is not parseable by TaskDoc (at least meaningfully). The structure is:
./{INCAR, KPOINTS, POTCAR}
./00/POSCAR
./01/{vasprun.xml, OSZICAR, OUTCAR, CHGCAR, ... }
./02/{vasprun.xml, OSZICAR, OUTCAR, CHGCAR, ... }
...
./0N/POSCAR

Approx / NEB calculations are needed for battery cathode and alloy diffusivity calculations. These schemas will be needed for atomate2 workflows. Once Approx / NEB flows are added to atomate2, we should have full parity with atomate. This will also make it easier to host data from these calculations

Supports parsing NEB calculations (only relaxes images) and NEB + endpoints (three total calculations, two relaxes + one NEB)

Possibly worth adding run / task / calc types? Since this requires a separate doc model, maybe we should avoid this?

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 93.10345% with 12 lines in your changes missing coverage. Please review.

Project coverage is 90.23%. Comparing base (96b4e93) to head (af9c949).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
emmet-core/emmet/core/neb.py 92.89% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1123      +/-   ##
==========================================
+ Coverage   90.18%   90.23%   +0.04%     
==========================================
  Files         147      148       +1     
  Lines       14504    14676     +172     
==========================================
+ Hits        13081    13243     +162     
- Misses       1423     1433      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants