Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Use a DataServer and MultiStore to pool connections #321

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

sivonxay
Copy link
Contributor

@sivonxay sivonxay commented May 18, 2023

Summary

  • Utilize MultiStore from fireworks DataServer to pool connections when accessing equivalent stores (when running fireworks on multiple processes).

TODO (if any)

  • This feature is dependent on a pull request in Fireworks and a pull request in Maggma
  • Check that all tests pass

Checklist

Before a pull request can be merged, the following items must be checked:

  • Code is in the standard Python style.
    The easiest way to handle this is to run the following in the correct sequence on
    your local machine. Start with running black on your new code. This will
    automatically reformat your code to PEP8 conventions and removes most issues. Then run
    pycodestyle, followed by flake8.
  • Docstrings have been added in theNumpy docstring format.
    Run pydocstyle on your code.
  • Type annotations are highly encouraged. Run mypy to
    type check your code.
  • Tests have been added for any new functionality or bug fixes.
  • All linting and tests pass.

Note that the CI system will run all the above checks. But it will be much more
efficient if you already fix most errors prior to submitting the PR. It is highly
recommended that you use the pre-commit hook provided in the repository. Simply
cp pre-commit .git/hooks and a check will be run prior to allowing commits.

@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #321 (361c129) into main (fb522a2) will decrease coverage by 0.77%.
The diff coverage is 35.29%.

❗ Current head 361c129 differs from pull request most recent head 21df1a6. Consider uploading reports for the commit 21df1a6 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #321      +/-   ##
===========================================
- Coverage   100.00%   99.23%   -0.77%     
===========================================
  Files           19       19              
  Lines         1429     1445      +16     
  Branches       361      365       +4     
===========================================
+ Hits          1429     1434       +5     
- Misses           0       10      +10     
- Partials         0        1       +1     
Impacted Files Coverage Δ
src/jobflow/core/store.py 97.70% <14.28%> (-2.30%) ⬇️
src/jobflow/managers/fireworks.py 92.75% <50.00%> (-7.25%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants