-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Flow.metadata
attribute and Flow.update_metadata
method
#679
Merged
Merged
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
b4b349d
add attributes metadata and metadata_updates to Flow class, now used …
janosh afdbb1f
test Flow.metadata and Flow.update_metadata
janosh 367836b
minor Job.metadata refactor
janosh e38237d
tweaks
janosh 9969640
drop target: Literal["flow", "jobs", "both"] = "both" from Flow.updat…
janosh c6a1732
remove target kwarg from Flow tests, skipping 2 that need further dis…
janosh dc23d2e
add keyword callback_filter: Callable[[jobflow.Flow | Job], bool] = l…
janosh aa4a02f
extensive unit tests for Flow and Job update_metadata callback_filter
janosh 1993511
delete test_flow_update_metadata_nested_flows
janosh 9f16d51
cover callback_filter in Flow.update_metadata in combo with dynamic=True
janosh b6786ca
document metadata + metadata_updates in Flow class doc str
janosh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please can you add docstrings for these options in the class docstring? E.g. see the corresponding docs for Job.