Merge pull request #8 from irzyxa/bug/av-on-destroy

Fixed AV on destroy when use SSL
mateusvicente100 · May 24, 2021 · f088466 · f088466
2 parents ded89ff + 2c2aba7
commit f088466
Showing 1 changed file with 15 additions and 4 deletions.
diff --git a/src/Bird.Socket.Client.pas b/src/Bird.Socket.Client.pas
@@ -37,6 +37,7 @@   TBirdSocketClient = class(TIdTCPClient)
     FOnHeartBeatTimer: TNotifyEvent;
     FOnUpgrade: TNotifyEvent;
     FSubProtocol: string;
+    FTaskReadFromWebSocket, FTaskHeartBeat: ITask;
     function GenerateWebSocketKey: string;
     function IsValidWebSocket: Boolean;
     function IsValidHeaders(const AHeaders: TStrings): Boolean;
@@ -233,7 +234,18 @@ constructor TBirdSocketClient.Create(const AURL: string);
 end;
 
 destructor TBirdSocketClient.Destroy;
+var
+  taskArray: array of ITask;
 begin
+  if FTaskReadFromWebSocket <> nil then
+    taskArray := taskArray + [FTaskReadFromWebSocket];
+  if FTaskHeartBeat <> nil then
+    taskArray := taskArray + [FTaskHeartBeat];
+  if Length(taskArray) > 0 then
+    TTask.WaitForAll(taskArray);
+  FTaskReadFromWebSocket := nil;
+  FTaskHeartBeat := nil;
+  SetLength(taskArray, 0);
   if FAutoCreateHandler and Assigned(FIOHandler) then
     FIOHandler.Free;
   FInternalLock.Free;
@@ -396,15 +408,14 @@ class function TBirdSocketClient.New(const AURL: string): TBirdSocketClient;
 
 procedure TBirdSocketClient.ReadFromWebSocket;
 var
-  LTask: ITask;
   LOperationCode: Byte;
   LSpool: TIdBytes;
 begin
   if not IsValidWebSocket then
     Exit;
   if not Connected then
     Exit;
-  LTask := TTask.Run(
+  FTaskReadFromWebSocket := TTask.Run(
     procedure
     var
       LByte: Byte;
@@ -532,7 +543,7 @@ procedure TBirdSocketClient.StartHeartBeat;
 var
   LDateLastNotify: TDateTime;
 begin
-  TThread.CreateAnonymousThread(
+  FTaskHeartBeat := TTask.Run(
     procedure
     begin
       LDateLastNotify := Now;
@@ -551,7 +562,7 @@ procedure TBirdSocketClient.StartHeartBeat;
         on E:Exception do
           HandleException(E);
       end;
-    end).Start;
+    end);
 end;
 
 function TBirdSocketClient.SetBit(const AValue: Cardinal; const AByte: Byte): Cardinal;