Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize eqfun and eqrel to dependent functions #1300

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Tragicus
Copy link
Contributor

@Tragicus Tragicus commented Nov 27, 2024

Motivation for this change

Generalizes eqfun and eqrel to dependent functions (which will be useful when we will want and be able to put instances on dependent function types). This changes the implicit arguments of _ =2 _ since now, in (f =2 g) x y, x appears in the type of y.

Minimal TODO list
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers
  • tried to abide by the contribution guide
  • this PR contains an optimum number of meaningful commits

See this Checklist for details.

Overlays
Automatic note to reviewers

Read this Checklist.

@CohenCyril
Copy link
Member

You could add an Arguments directive to preserve the former implicits. I think in this particular case I'd rather put one _ to omit a redundant argument in the dependent case rather than use @ and put many _ in the non-dependent case...

@Tragicus
Copy link
Contributor Author

I can not access x to make it explicit without changing the type of eqrel _ _, which would break things very hard. coq/coq#13435 seems to imply that this issue is by design (see also this Zulip thread)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants