Fix NSArray Error #157
Merged
Fix NSArray Error #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix NSArray error
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two issues reported: #154 and #155
On Mac OS 10.13 and Sketch version 47 committing and generating files for pretty diffs resulted in NSArray errors. I found a similar issue tudou527/marketch#158 in another sketch plugin and was able to debug this issue.
I tested this locally and was able to both commit and generate files via "Generate files for pretty diffs"
I wasn't sure if I should bump the version but I did anyway - happy to make any changes.