Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy ref #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

deploy ref #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/cd-tag-release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ on:
team:
required: true
type: string
deploy_ref:
required: false
type: string

jobs:
deploy-each:
Expand All @@ -31,7 +34,7 @@ jobs:
case "frontend":
return context.ref == "refs/heads/main"
case "devops":
return context.ref == "refs/heads/master"
return context.ref == "${{ inputs.deploy_ref }}"
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blue-hope
checkBranch 에서 deploy_ref가 있으면 이걸로 비교하고,
없으면 기존 로직 타도록 해도 괜찮을 것 같습니다.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그냥 브랜치 상관없이 버튼만 누를 수 있게 하는 조치인거죠?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blue-hope
@jisujisu1232 는 이렇게 쓰고 싶어하는 것 같습니다.

return false
}
Expand Down