Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC Tests on CI #1462

Merged
merged 6 commits into from
Feb 25, 2025
Merged

RPC Tests on CI #1462

merged 6 commits into from
Feb 25, 2025

Conversation

lucca30
Copy link
Contributor

@lucca30 lucca30 commented Feb 24, 2025

Description

This PR aims include RPC Tests on the CI process. In order to do that we first need to merge the new changes on matic cli (without it, the CI will fail). It will allows us to run the current whole suitcase of RPC tests (47 testcases).

Success example:

success_test

Failure example

failure_test

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai/amoy
  • I have created new e2e tests into express-cli

@lucca30 lucca30 marked this pull request as ready for review February 24, 2025 20:20
@lucca30 lucca30 requested a review from a team February 25, 2025 03:36
@lucca30 lucca30 requested a review from a team February 25, 2025 12:53
@lucca30 lucca30 merged commit be9ac0c into develop Feb 25, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants