feat: force flags with --

[mrostamii]

Description

We addressed an issue where the bridge flag was ignored when we used it like bridge --all. So, in this PR, we ensure all flags must start with --.

Changes

Added a statement on RunE to check if all of the used flags to run the app are started with --FLAG.

• Bugfix (non-breaking change that solves an issue)
• Hotfix (change that solves an urgent issue, and requires immediate attention)
• New feature (non-breaking change that adds functionality)
• Breaking change (change that is not backwards-compatible and/or changes current functionality)
• Changes only for a subset of nodes

Nodes audience

No need to modify any nodes and service file. It just prevents the app from starting with a wrong flag that would be ignored.

Checklist

• I have added at least 2 reviewer or the whole pos-v1 team
• I have added sufficient documentation in code
• I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Cross repository changes

• This PR requires changes to bor
  • In case link the PR here:
• This PR requires changes to matic-cli
  • In case link the PR here:

Testing

• I have added unit tests
• I have added tests to CI
• I have tested this code manually on local environment
• I have tested this code manually on remote devnet using express-cli
• I have tested this code manually on mumbai
• I have created new e2e tests into express-cli

Manual tests

Head to the repository path, then run the app:

go run ./cmd/heimdalld/main.go start --home "$HOME/heimdall" bridge --all --chain=mainnet --rest-server

The response is:

ERROR:  invalid argument: bridge 
        all flags must start with --
exit status 1

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

see 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

[VAIBHAVJINDAL3012]

Hi @mrostamii
Changes seems good to me , but for an extra confirmation I will run this on the local devnet and approve this PR by this weekend.

[github-actions]

This PR is stale because it has been open 21 days with no activity. Remove stale label or comment or this will be closed in 14 days.

[marcello33]

Thanks @mrostamii, we'll be merging this!