Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: log/service stopped #1070

Merged
merged 2 commits into from
Oct 26, 2023
Merged

fix: log/service stopped #1070

merged 2 commits into from
Oct 26, 2023

Conversation

mrostamii
Copy link
Contributor

Description

The log of Heimdall services stopped was in a wrong place where it printed this log where any heimdalld sub-command (e.g., version, init) has called.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Cross repository changes

  • This PR requires changes to bor
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

Manual tests

Following we test the version sub-command.

out of this PR

/usr/bin/heimdalld version
1.0.1
INFO [2023-10-02|14:09:17.940] Heimdall services stopped                    module=cmd/heimdalld

in this PR

/usr/bin/heimdalld version
1.0.1

The same would apply to all other sub-commands.

@mrostamii
fix: log/service stopped
640b2ca 
- was in wrong section, any other subcommand have affected
Raneet10
Raneet10 approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@Raneet10 Raneet10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the PR!

@codecov
Copy link

codecov bot commented Oct 5, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

see 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@anshalshukla
Copy link
Contributor

@mrostamii can you fix the linting errors

@mrostamii
fix: wsl error
8de3320 
- added an empty line before the `return nil` statement
@marcello33 marcello33 merged commit 0e70ceb into maticnetwork:develop Oct 26, 2023
9 checks passed
Raneet10 pushed a commit that referenced this pull request Feb 13, 2024
@mrostamii @Raneet10
fix: log/service stopped (#1070)
6d17c98 
* fix: log/service stopped
- was in wrong section, any other subcommand have affected

* fix: wsl error
- added an empty line before the `return nil` statement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raneet10 Raneet10 Raneet10 approved these changes

@marcello33 marcello33 marcello33 approved these changes

@0xsharma 0xsharma 0xsharma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mrostamii @anshalshukla @0xsharma @marcello33 @Raneet10