Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master to develop #1133

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Conversation

Raneet10
Copy link
Member

Description

Merge master to develop (post conflict resolve).

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

* Added Bridge README

* Update README

* Add FAQ

* Fix

* Fix
@Raneet10 Raneet10 requested a review from a team February 14, 2024 07:55
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dbabaa3) 76.59% compared to head (98ac057) 76.59%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1133   +/-   ##
========================================
  Coverage    76.59%   76.59%           
========================================
  Files           53       53           
  Lines         5922     5922           
========================================
  Hits          4536     4536           
  Misses        1128     1128           
  Partials       258      258           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Raneet10 Raneet10 merged commit 12ce095 into develop Feb 14, 2024
11 checks passed
@Raneet10 Raneet10 deleted the raneet10/master-to-develop-conflicts branch February 14, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants