Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POS-2821: improvements #1233

Merged
merged 12 commits into from
Feb 8, 2025
Merged

POS-2821: improvements #1233

merged 12 commits into from
Feb 8, 2025

Conversation

marcello33
Copy link
Contributor

@marcello33 marcello33 commented Feb 6, 2025

Description

This PR contains the following improvements:

  • Bump golang version
  • Bump GH actions' versions
  • Fix govulncheck, add make vulncheck command, create its own CI without using the Templum GH action and fail the CI in case of errors
  • Solve some linting issues
  • Solve some GHE problems

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai or amoy
  • I have created new e2e tests into express-cli

@marcello33 marcello33 changed the base branch from master to develop February 6, 2025 10:17
@marcello33 marcello33 changed the title Mardizzone/pos 2821 POS-2821: GHE fixes Feb 6, 2025
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.24%. Comparing base (298d62f) to head (ac7d4b6).
Report is 104 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1233       +/-   ##
============================================
- Coverage    76.36%   65.24%   -11.13%     
============================================
  Files           53       65       +12     
  Lines         5932     6974     +1042     
============================================
+ Hits          4530     4550       +20     
- Misses        1141     2162     +1021     
- Partials       261      262        +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcello33 marcello33 changed the title POS-2821: GHE fixes POS-2821: improvements Feb 7, 2025
@marcello33 marcello33 requested a review from a team February 7, 2025 13:10
@marcello33 marcello33 merged commit a7033fa into develop Feb 8, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants