Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for README, docker config and environment #242

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

chetanyb
Copy link
Contributor

Description

  • Added a step-by-step guide in the README for installing the necessary tools to run matic-cli locally on macOS using Docker.
  • Corrected minor typos in the existing documentation for improved clarity.
  • Additional changes in README, docker config and env.example for better clarity and GCP support info

Changes

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • New test case for remote devnet

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Cross repository changes

It should never be the case...

  • This PR requires changes to bor
    • In case link the PR here:
  • This PR requires changes to heimdall
    • In case link the PR here:

Testing

  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai or amoy

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@chetanyb chetanyb requested a review from a team September 11, 2024 04:44
@chetanyb chetanyb requested a review from a team September 12, 2024 03:51
@marcello33 marcello33 mentioned this pull request Sep 12, 2024
12 tasks
@marcello33 marcello33 merged commit e7c8829 into master Sep 17, 2024
5 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants