Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some wrong names #460

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
:wave:

Thank you for reading this file! We'd love to see you help us make this package even better than it is. Since we are all working on Kayu in our free time, it's important that we follow some set of guidelines to make communication easier. Read this guideline to learn what we have in mind.
Thank you for reading this file! We'd love to see you help us make this package even better than it is. Since we are all working on nookies in our free time, it's important that we follow some set of guidelines to make communication easier. Read this guideline to learn what we have in mind.

### Language & Community

Expand All @@ -18,7 +18,7 @@ Alright, so you want a new feature, right? Me too! Everyone wants a new feature

This is a community driven project. Nobody is paid to work on it. Keep that in mind at all times.

To save people working on Kayu some time, first check other issues and discussions to see if somebody has requested a similar feature. It's a lot easier for us to prioritise tasks and implement a feature if we see a flourishing discussion in one of the feature requests. Share your thoughts, do research.
To save people working on nookies some time, first check other issues and discussions to see if somebody has requested a similar feature. It's a lot easier for us to prioritise tasks and implement a feature if we see a flourishing discussion in one of the feature requests. Share your thoughts, do research.

We are inclined to read well structured arguments. If your request hasn't received much attention in say a month, try to do some research on it and share your findings. The more knowledge there already is, the easier (and faster) your feature will be implemented.

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export async function getServerSideProps(ctx) {
const cookies = nookies.get(ctx)

// Set
nookies.set(ctx, 'fromGetInitialProps', 'value', {
nookies.set(ctx, 'fromGetServerSideProps', 'value', {
maxAge: 30 * 24 * 60 * 60,
path: '/',
})
Expand Down
2 changes: 1 addition & 1 deletion packages/nookies/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ export function setCookie(
parsedCookie.name,
parsedCookie.value,
{
// we prevent reencoding by default, but you might override it
// we prevent re-encoding by default, but you might override it
encode: (val: string) => val,
...(parsedCookie as cookie.CookieSerializeOptions),
},
Expand Down