fix: make express and cookie types dependencies #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @maticzav, are you interested in this? I could rebase this PR, if you want. |
|
i had the samething for running project and i change yarn-berry to yarn-3.. and everything was ok (with but why we should change types to deps? these are only Types for typescript and at the end we need them only before building the project, so i think this could harm the package size and we should seek a better solution for that. |
|
Did you read the issue this relates to? Iirc, some types exposed by this library rely on these, not installing them makes them |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #492
I have no yarn2 experience at all. I did run
yarn set version berrybefore runningyarn install, I thought that was the right thing to do.