Reduce MSRV to 1.65 by polyfilling AtomicUsize::as_ptr().
#277
+24
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! Please also bump patch version in Cargo.toml and add a changelog entry! |
briansmith
changed the title
AtomicUsize::as_ptr().AtomicUsize::as_ptr().
briansmith
force-pushed
the
b/as-ptr
branch
2 times, most recently
from
e4face9 to
9e01e87
Compare
Potentially the MSRV could be reduced further as `cargo +1.63.0 check` passes, but `cargo +1.63.0 test` fails: ``` $ cargo +1.63.0 test error: package `regex-syntax v0.8.5` cannot be built because it requires rustc 1.65 or newer, while the currently active rustc version is 1.63.0 ```
|
I have updated the PR to set MSRV to 1.65 since that is the minimum for |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially the MSRV could be reduced further as
cargo +1.63.0 checkpasses, butcargo +1.63.0 testfails: