Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better better support for sending events in the background #359

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

brototyp
Copy link
Member

@brototyp brototyp commented Nov 1, 2020

This PR tries to fix issues (#331, #327) when bringing the app to the background, while dispatching events.

There are multiple approaches.

  1. Ensure retransmission of the same event doesn't lead to duplicate events in the backend. This requires changes on the backend side.
  2. Uploading events using a background URLSession. Downside of this approach is that a background session doesn't guarantee timely execution of the request and doesn't give us too much / enough control over how requests are sent or re-sent.
  3. Starting a background task before transmitting and ending it right after. This is the approach taken in this PR:

@brototyp-bot
Copy link

1 Error
🚫 Please add a line to the CHANGELOG.md since you changed the SDK.
1 Warning
⚠️ Are there any changes that should be explained in the README.md?

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants