Fixes fatal error on Windows due to readline_callback_handler_install…

… method not present, #269
matomo-org · Oct 21, 2024 · 2d234a5 · 2d234a5
1 parent 45214e2
commit 2d234a5
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,8 @@
 ## Changelog
 
+5.1.0 - 2021-10-22
+- Fixes fatal error on Windows due to readline_callback_handler_install method not present
+
 5.1.0 - 2021-10-21
 - Increased number of queue tracking workers to 4096
 - Enhance queue monitor and process commands

diff --git a/Commands/Monitor.php b/Commands/Monitor.php
@@ -71,8 +71,10 @@ protected function doExecute(): int
         $qPerPAge       = min(max($this->getPerPageFromArg(), 1), $qCount);
         $qPageCount     = ceil($qCount / $qPerPAge);
 
-        readline_callback_handler_install('', function () {
-        });
+        if (function_exists('readline_callback_handler_install')) {
+            readline_callback_handler_install('', function () {
+            });
+        }
         stream_set_blocking(STDIN, false);
 
         $output->writeln(str_repeat("-", 30));

diff --git a/plugin.json b/plugin.json
@@ -1,6 +1,6 @@
 {
     "name": "QueuedTracking",
-    "version": "5.1.0",
+    "version": "5.1.1",
     "description": "Scale your large traffic Matomo service by queuing tracking requests in Redis or MySQL for better performance and reliability when experiencing peaks.",
     "theme": false,
     "keywords": ["tracker", "tracking", "queue", "redis"],