-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
increase worker number to 4096 #260
increase worker number to 4096 #260
Conversation
@haristku FYI, I tried fixing the failing tests but 1 test is failing randomly after this change, I would spend more time tomorrow to see if we can fix that test or not. |
Co-authored-by: Altamash Shaikh <[email protected]>
@haristku It's looking good and it works as expected when I run it in my local environment. Can you please update these lines of SettingsTest to be the following?
|
Never mind. Looks like Altamash got it 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, we can update the UI tests once the PR is merged
@snake14 Cam you check if we can merge this PR ? |
@AltamashShaikh Yep. With all builds passing except UI, I think we're good to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, no issues found during functional testing, and all but UI build are passing 👍
Description:
breaking down the previous PR to specific part