enhanced monitor, process commands

[haristku]

Description:

breaking down the previous PR to specific part

• enhanced monitor, process commands

[snake14]

The Process changes look good and work as expected 👍

When I tried testing the Monitor changes, the paging didn't appear to work. It would insert new lines above the window height and the visible portion of the window didn't change. It appeared to be appending the help text after some of the lines as well.

[haristku]

@snake14
what OS are you using to run the Monitor command? do you use *nix terminal or windows PowerShell or CMD?

unfortunately, i'm not running matomo in a Windows environment, so i don't have a chance to see the "Monitor" output in a Windows console like PowerShell or CMD..

🙏 ✌️

[snake14]

@snake14 what OS are you using to run the Monitor command? do you use *nix terminal or windows PowerShell or CMD?

unfortunately, i'm not running matomo in a Windows environment, so i don't have a chance to see the "Monitor" output in a Windows console like PowerShell or CMD..

🙏 ✌️

@haristku I'm running Ubuntu 22.04 and using the stock terminal.

[haristku]

The Process changes look good and work as expected 👍

When I tried testing the Monitor changes, the paging didn't appear to work. It would insert new lines above the window height and the visible portion of the window didn't change. It appeared to be appending the help text after some of the lines as well.

what if you add 3 rows per page args:

php console queuedtracking:monitor -p 3

what's the result? is the paging working or still not?

---

the default rows per page is 16, if we have 16 workers it means we only have 1 page, so the paging feature won't work, but if we set the workers to 34, it means we have 3 pages and the paging feature will work, and we can use the right, left, up, down arrows to navigate through the page. the total pages is displayed at the bottom Q [0-15] | page 1/3 | press (0-9.,q) or arrow(L,R,U,D) | diff/sec 0

and the help description also included in:

php console help queuedtracking:monitor

Description:
  Shows and updates the current state of the queue every 2 seconds.
  Key ,=first page, .=last page, 0-9=move to page section, arrow LEFT=prev page, RIGHT=next page, UP=next 10 pages, DOWN=prev 10 pages, q=quit

-p, --perpage=PERPAGE                Number of queue worker displayed per page. [default: 16]

---

we already split the PR into smaller parts, in this PR we cannot have workers higher than 16, therefore we can use -p parameter to simulate pages

---

i still want to update this PR to remove the use of PCNTL completely... i'll update it tomorrow...

ty.

[snake14]

Thank you for the suggestion of changing the page size. That helped me test some variations. Although, I tested without setting a specific page size again and it worked correctly. I'm not sure what the issue was last time I tested. I'm approving the PR 👍

[AltamashShaikh]

Looks okay to me, left 1 comment.

[haristku]

Looks okay to me, left 1 comment.

pcntl usage removed. the consequence is blinking cursor on monitor command… coz cursor hide and show mechanism cannot be restored without pcntl sigterm.

@AltamashShaikh @snake14 , have you ever tried the monitor command in a Windows environment?
i hope the output and functionality can be the same in all environments.

[snake14]

Looks okay to me, left 1 comment.

pcntl usage removed. the consequence is blinking cursor on monitor command… coz cursor hide and show mechanism cannot be restored without pcntl sigterm.

@AltamashShaikh @snake14 , have you ever tried the monitor command in a Windows environment? i hope the output and functionality can be the same in all environments.

@haristku Thank you for all of your effort. I think that the PR looks ready to merge. Sadly, I don't think we currently have a Windows environment to test with. @AltamashShaikh Do you think that we're alright to merge anyway?

[AltamashShaikh]

@snake14 We can merge this and address the concern for windows if any

[haristku]

@haristku Thank you for all of your effort. I think that the PR looks ready to merge. Sadly, I don't think we currently have a Windows environment to test with. @AltamashShaikh Do you think that we're alright to merge anyway?

thanks for creating matomo and this plugin in the first place. 👍

btw, i forgot to remove these 2 lines, my intention is to clear the screen, but it seems unnecessary, you can remove them.✌️

[AltamashShaikh]

@haristku Did you mean this 2 lines ?

[haristku]

@haristku Did you mean this 2 lines ?

yes...

[haristku]

and 1 more update, change this line to this:

$diffSumInQueue = $diffSumInQueue < 0 ? "<fg=red;options=bold>" . number_format(abs($diffRps)) . "</>" : "<fg=green;options=bold>" . number_format($diffRps) . "</>";

✌️

[AltamashShaikh]

@haristku All done and released v5.1.0 of the plugin.

[haristku]

ty sir... 🫡