Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for MSC3757 #733

Merged
merged 11 commits into from
Sep 25, 2024
Merged

Add tests for MSC3757 #733

merged 11 commits into from
Sep 25, 2024

Conversation

AndrewFerr
Copy link
Member

Signed-off-by: Andrew Ferrazzutti [email protected]

Pull Request Checklist

AndrewFerr added a commit to AndrewFerr/synapse that referenced this pull request Sep 16, 2024
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions, but otherwise this LGTM!

tests/msc3757/owned_state_test.go Outdated Show resolved Hide resolved
tests/msc3757/owned_state_test.go Show resolved Hide resolved
@AndrewFerr
Copy link
Member Author

Note that I've also made analogous test updates to Synapse: element-hq/synapse#17513 (commits)

tests/msc3757/owned_state_test.go Outdated Show resolved Hide resolved
tests/msc3757/owned_state_test.go Outdated Show resolved Hide resolved
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending @kegsay's suggestions above, this LGTM.

Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to merge. There are still outstanding questions on the MSC, which is evolving, but further tests/changes can always be added later.

@anoadragon453 anoadragon453 merged commit 911d7d3 into matrix-org:main Sep 25, 2024
4 checks passed
@AndrewFerr AndrewFerr deleted the af/msc3757 branch September 25, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants