-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for MSC3757 #733
Conversation
Make more like its analogous Synapse unit test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor suggestions, but otherwise this LGTM!
Note that I've also made analogous test updates to Synapse: element-hq/synapse#17513 (commits) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending @kegsay's suggestions above, this LGTM.
to avoid confusion with a server administrator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to merge. There are still outstanding questions on the MSC, which is evolving, but further tests/changes can always be added later.
Signed-off-by: Andrew Ferrazzutti [email protected]
Pull Request Checklist