Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use latest data structure for acccount testing #735

Merged
merged 5 commits into from
Sep 26, 2024

Conversation

chrislearn
Copy link
Contributor

@chrislearn chrislearn commented Sep 11, 2024

Hello,
I am using Rust to develop a matrix server-side Palpo, which is based on another web framework I maintain, Salvo. When using complement for testing, I found that several places seemed to use the old data format, which caused some of my tests to fail. I am not sure whether it needs to be fixed.

Signed-off-by: Chrislearn Young [email protected]

@chrislearn chrislearn requested review from a team as code owners September 11, 2024 21:21
@chrislearn chrislearn changed the title fix: Use latest data struce for acccount testing fix: Use latest data structure for acccount testing Sep 11, 2024
@kegsay
Copy link
Member

kegsay commented Sep 25, 2024

Please sign-off as per https://github.com/matrix-org/complement/blob/main/CONTRIBUTING.md#sign-off in the comment of this PR.

@chrislearn
Copy link
Contributor Author

Please sign-off as per https://github.com/matrix-org/complement/blob/main/CONTRIBUTING.md#sign-off in the comment of this PR.

Done

@kegsay
Copy link
Member

kegsay commented Sep 26, 2024

Dunno why signoff is complaining. LGTM

@kegsay kegsay merged commit c246a09 into matrix-org:main Sep 26, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants