Add more logging to attendance command #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
H-Shay
commented
Nov 7, 2023
| @@ -15,7 +15,6 @@ limitations under the License. | |||
| */ | |||
|
|
|||
| import { ICommand } from "./ICommand"; | |||
| import { MatrixClient } from "matrix-bot-sdk"; | |||
There was a problem hiding this comment.
This is a drive-by cleanup - the import was unused.
H-Shay
force-pushed
the
shay/attendance_logging
branch
from
8e1659f
to
8b8357e
Compare
Half-Shot
approved these changes
Nov 7, 2023
src/commands/AttendanceCommand.ts
Outdated
| await append(inviteTargets, null, await spiRoom.getId(), spiRoom.roomId, null, doAppend); | ||
| } | ||
| catch (error) { | ||
| throw new Error(`Error calculating invite acceptance in special interest room ${spiRoom}: ${error.toString()}`) |
There was a problem hiding this comment.
Suggested change
| throw new Error(`Error calculating invite acceptance in special interest room ${spiRoom}: ${error.toString()}`) | |
| throw new Error(`Error calculating invite acceptance in special interest room ${spiRoom}`, {cause: error }); |
Gives you a nice stacktrack
> new Error('Oh no, an error', { cause: new Error('caused by this cheeky thing')})
Error: Oh no, an error
at REPL2:1:1
at Script.runInThisContext (node:vm:121:12)
... 7 lines matching cause stack trace ...
at [_line] [as _line] (node:internal/readline/interface:887:18) {
[cause]: Error: caused by this cheeky thing
at REPL2:1:39
at Script.runInThisContext (node:vm:121:12)
at REPLServer.defaultEval (node:repl:593:29)
at bound (node:domain:432:15)
at REPLServer.runBound [as eval] (node:domain:443:12)
at REPLServer.onLine (node:repl:923:10)
at REPLServer.emit (node:events:526:35)
at REPLServer.emit (node:domain:488:12)
at [_onLine] [as _onLine] (node:internal/readline/interface:416:12)
at [_line] [as _line] (node:internal/readline/interface:887:18)
}
This feature is not used nearly enough https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/Error#cause
There was a problem hiding this comment.
Cool thanks for the insight - I am new to typescript/javascript so appreciate the tips :)
|
Merged #195 into main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title states. Part of the effort to add some more useful logging to the commands.