Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a powerlevel command #226

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Add a powerlevel command #226

merged 1 commit into from
Feb 2, 2024

Conversation

H-Shay
Copy link
Contributor

@H-Shay H-Shay commented Feb 2, 2024

Adds a command that will elevate the power level of the given user in the given room or room group. Heavily inspired by the inviteme command.

@H-Shay H-Shay requested a review from a team as a code owner February 2, 2024 18:03
let targetId = args[0]
let pl = args[2]

const IM = new InviteMeCommand(this.client, this.conference);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is probably terrible - is there a better way to import functions from another class ala Python?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd probably normally pull out the function so it's not in the class itself, but 'meh' for now

let targetId = args[0]
let pl = args[2]

const IM = new InviteMeCommand(this.client, this.conference);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd probably normally pull out the function so it's not in the class itself, but 'meh' for now

@reivilibre reivilibre merged commit d2ce0a5 into main Feb 2, 2024
5 checks passed
@reivilibre reivilibre deleted the shay/power_level_command branch February 2, 2024 21:10
reivilibre added a commit that referenced this pull request Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants