Update auditorium names to be the track name on talk start #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Half-Shot
requested changes
Feb 4, 2024
src/Scheduler.ts
Outdated
|
|
||
| try { | ||
| const nameEventContent = await this.client.getRoomStateEvent(confAud.roomId, "m.room.name", ""); | ||
| if (task.talk.track != '' && task.talk.track != undefined && task.talk.track != nameEventContent["name"]) { |
There was a problem hiding this comment.
You can test some of these conditions prior to pulling state.
There was a problem hiding this comment.
That's true. In some respects I'm not expecting these things to happen, but I just didn't want the bot to go and do a silly if they actually did.
Co-authored-by: Will Hunt <[email protected]>
Half-Shot
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pulled from FOSDEM 2024 Hotfixes #228
A nice-to-have would be to update on Sunday before the first talk even starts (and maybe slightly in advance of the changeover halfway through the day too).
But that would have been complicated to do and we needed something simple and robust on the day.