For support room invites, fix multiple-role people not being invited #231

reivilibre · 2024-02-04T10:47:16Z

Pulled out of FOSDEM 2024 hotfixes #228

Two things here:

in the general case, we make it so that the Coordinator trumps Speaker. This at least makes it a little more deterministic when there's a conflict, but I think we ought to consider supporting multiple role people a bit more natively/robustly in the future. (but at short-notice, this would have been too error-prone to do)
for the support room invite case, we fix dual-role wielders not being invited to the right room, by applying the correct filtering at the source to avoid role conflicts messing stuff up.

This is because the speakers room should not have devroom managers

turt2live

This looks correct, I think. Apologies for the delay :(

reivilibre added 2 commits February 4, 2024 10:43

HACK Coordinator role trumps Speaker role

cd1fe40

Apply invite target filtering at the source, before role trumps

e87a1ea

This is because the speakers room should not have devroom managers

reivilibre requested a review from a team as a code owner February 4, 2024 10:47

turt2live approved these changes May 13, 2024

View reviewed changes

reivilibre merged commit 340b81a into main Jun 3, 2024
5 checks passed

reivilibre deleted the rei/fd24_role_filtering_at_source branch June 3, 2024 10:57

Provide feedback