Skip to content
This repository has been archived by the owner on Nov 25, 2024. It is now read-only.

Slightly refactor latestEventsUpdater #3272

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

S7evinK
Copy link
Contributor

@S7evinK S7evinK commented Nov 23, 2023

In an attempt to make testing the latestEventsUpdater easier, some moving around of variables and method calls.

@S7evinK S7evinK added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Nov 23, 2023
@S7evinK S7evinK requested a review from a team as a code owner November 23, 2023 18:51
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Attention: Patch coverage is 52.38095% with 30 lines in your changes missing coverage. Please review.

Project coverage is 67.53%. Comparing base (9897959) to head (928f3a0).
Report is 5 commits behind head on main.

Files Patch % Lines
roomserver/internal/input/input_latest_events.go 52.38% 23 Missing and 7 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3272      +/-   ##
==========================================
- Coverage   67.54%   67.53%   -0.01%     
==========================================
  Files         521      521              
  Lines       47381    47384       +3     
==========================================
+ Hits        32002    32003       +1     
- Misses      11394    11397       +3     
+ Partials     3985     3984       -1     
Flag Coverage Δ
unittests 52.81% <52.38%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant