Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Helm packages generated end up in docs/ subpath that's hosted #3427

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

Arkaniad
Copy link
Contributor

I've noticed that Chart Releaser is behaving improperly, and not successfully putting the charts where gh-pages will hots them and generating invalid index.

This change should ensure built charts end up in the docs/ subpath, which should ensure that gh-pages branch isn't getting an invalid index.yaml and new charts should be automatically available.

Pull Request Checklist

Signed-off-by: Rhea Danzey <[email protected]>

@Arkaniad Arkaniad requested a review from a team as a code owner September 18, 2024 16:32
Copy link
Contributor

@S7evinK S7evinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh, thank you for taking a look at that, I meant to do that after the release on Friday.

@S7evinK S7evinK merged commit 3530d29 into main Sep 18, 2024
2 checks passed
@S7evinK S7evinK deleted the rdanzey/fix-chart-deployment branch September 18, 2024 18:21
@S7evinK
Copy link
Contributor

S7evinK commented Sep 18, 2024

Looks like that didn't do the right thing. :(
Wondering if moving back to latest fixes that?

- name: Run chart-releaser
uses: helm/chart-releaser-action@ed43eb303604cbc0eeec8390544f7748dc6c790d # specific commit, since `mark_as_latest` is not yet in a release
env:
CR_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
with:
config: helm/cr.yaml
charts_dir: helm/
mark_as_latest: false

@Arkaniad
Copy link
Contributor Author

It seems worth a try! I'm puzzled why it's not generating links to the release tarball as it seems to have been..

@Arkaniad
Copy link
Contributor Author

Trying here

I'll merge it unless there's any objections, and if it doesn't fix I'll only spend a little more time pushing it and failing that just fix up the index manually and leave it there for now

S7evinK pushed a commit that referenced this pull request Sep 18, 2024
Context:
#3427 (comment)

Try tagged version of chart-releaser-action now that mark_latest option
is available

### Pull Request Checklist

<!-- Please read
https://matrix-org.github.io/dendrite/development/contributing before
submitting your pull request -->

* [x] I have added Go unit tests or [Complement integration
tests](https://github.com/matrix-org/complement) for this PR _or_ I have
justified why this PR doesn't need tests
* [x] Pull request includes a [sign off below using a legally
identifiable
name](https://matrix-org.github.io/dendrite/development/contributing#sign-off)
_or_ I have already signed off privately

Signed-off-by: `Rhea Danzey <[email protected]>`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants