Upgrade Emojibase and Add emoticon variations #21
Conversation
…langleyd/add_emoticon_permutations
…langleyd/add_emoticon_permutations
langleyd
requested review from
a team and
florianduros
and removed request for
a team
|
Dropping in uninvited to ask an important question!
Does this work per platform? Apple supports 15.1 and I'd love to get the 🙂 |
|
@pixlwave yea we could probably load it via an |
|
Amazing, thank you! 🙌 |
langleyd
changed the title
|
@bmarty We've split out the max emoji version per platform as per the PR description. Would you(Android) like add emoji 15.1 support similar to iOS? (Web needs to stay on 15.0 for now). |
src/emoji.ts
Outdated
| for (const [versionString, emojis] of Object.entries(VERSIONS)) { | ||
| const version = parseFloat(versionString); | ||
| emojis.forEach((emoji) => EMOJI_TO_VERSION.set(emoji, version)); | ||
| } |
There was a problem hiding this comment.
A comment is welcomed to explain why we need it
| //flatten, in case `emoji.emoticon` is an array | ||
| .flat() | ||
| .flatMap((x) => generateEmoticonPermutations(x)); | ||
| emoticons.forEach((x) => EMOTICON_TO_EMOJI.set(x, emoji)); |
There was a problem hiding this comment.
It's feel wrong to me to mutate a map/array when doing a map another array.
There was a problem hiding this comment.
Yes, true I found that strange also, I wasn't too comfortable making those logic changes before as there wasn't much tests but we have that now :). Will move the logic that isn't related to the map out to a foreach so it's a bit clearer.
|
Confirmed with Android team they want to move to 15.1. |
What's in this PR
generateEmoticonPermutationsto generate variations of plain text emoticons(e.g. with or without nose:):-)).MAX_EMOJI_VERSION_WEBto filter out newer emojis from inclusion as web is not ready to upgrade yet (it needs to be upgraded in unison withtwemoji(which is awkward and beyond the scope of this PR)MAX_EMOJI_VERSION_ANDROIDandMAX_EMOJI_VERSION_IOSto the script that generates theemojibase.jsonfor those platforms so that they can move forward.