Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tell the homeserver if a room alias request failed #655

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Tell the homeserver if a room alias request failed #655

wants to merge 7 commits into from

Conversation

jaller94
Copy link
Contributor

Adds more TypeScript annotations to MatrixRoomHandler.

@jaller94
Copy link
Contributor Author

What is supposed to happen here?
https://github.com/Half-Shot/matrix-appservice-discord/blob/c29cfc72f55f1f81e43e2d71f5c080d752d1a884/src/discordas.ts#L193-L194

createRoomOpts can be undefined.

@Half-Shot
Copy link
Contributor

@jaller94 If createRoomOpts comes back as undefined, we should call createRoom with false and return early, which will tell the homeserver that the alias request failed.

@jaller94
Copy link
Contributor Author

I resolved the merge conflict.

@jaller94
Copy link
Contributor Author

According to the type definition in matrixroomhandler.ts the property createRoomOpts.__roomId does not exist.

@Half-Shot
Copy link
Contributor

Half-Shot commented Jan 26, 2021 •
edited by jaller94
Loading

https://github.com/turt2live/matrix-bot-sdk/blob/master/src/appservice/Appservice.ts#L694

Permalink: https://github.com/turt2live/matrix-bot-sdk/blob/d4877afd9c3555970eeb047d4ed590955b58709a/src/appservice/Appservice.ts#L694

@jaller94
Copy link
Contributor Author

Ok, I added it to the type in matrixroomhandler.ts.

@jaller94 jaller94 requested a review from a team May 19, 2022 14:26
@jaller94 jaller94 force-pushed the j94/matrixroomhandler-types branch from 74958ce to 45a1a0f Compare August 4, 2022 23:10
@jaller94 jaller94 changed the title Add more types to MatrixRoomHandler Tell the homeserver if a room alias request failed Aug 9, 2022
@jaller94
Copy link
Contributor Author

In reply to #655 (comment)

@Half-Shot __index doesn't seem to be in the code of matrix-bot-sdk anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaller94 @Half-Shot