docker: don't push on a Pull Request (#1767)

* docker: don't push on a Pull Request Since the github action triggers on a PR too, `github.ref` will be the target branch for merging (typically `develop`). In that case, don't try to login/push to docker hub. https://docs.github.com/en/actions/learn-github-actions/contexts#github-context Signed-off-by: Дамјан Георгиевски <[email protected]> * Create 1767.bugfix * check if env.PUSH is the "true" string Signed-off-by: Дамјан Георгиевски <[email protected]> --------- Signed-off-by: Дамјан Георгиевски <[email protected]> Co-authored-by: Will Hunt <[email protected]>
matrix-org · Aug 8, 2023 · 4163275 · 4163275
1 parent 8953058
commit 4163275
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/.github/workflows/docker-hub-latest.yml b/.github/workflows/docker-hub-latest.yml
@@ -11,7 +11,8 @@ env:
   DOCKER_NAMESPACE: matrixdotorg
   PLATFORMS: linux/amd64
   # Only push if this is develop, otherwise we just want to build
-  PUSH: ${{ github.ref == 'refs/heads/develop' }}
+  # On a PR github.ref is the target branch, so don't push for that either
+  PUSH: ${{ github.ref == 'refs/heads/develop' && github.event_name != 'pull_request' }}
 
 jobs:
   docker-latest:
@@ -21,7 +22,7 @@ jobs:
         uses: actions/checkout@v3
       - name: Login to Docker Hub
         uses: docker/login-action@v2
-        if: ${{ env.PUSH }}
+        if: ${{ env.PUSH == 'true' }}
         with:
           username: ${{ secrets.DOCKER_HUB_USERNAME }}
           password: ${{ secrets.DOCKER_HUB_TOKEN }}
@@ -34,4 +35,4 @@ jobs:
           platforms: ${{ env.PLATFORMS }}
           push: ${{ env.PUSH }}
           tags: |
-            ${{ env.DOCKER_NAMESPACE }}/matrix-appservice-irc:latest
+            ${{ env.DOCKER_NAMESPACE }}/matrix-appservice-irc:latest
diff --git a/changelog.d/1767.bugfix b/changelog.d/1767.bugfix
@@ -0,0 +1 @@
+Fix GitHub CI docker builds failing for community PRs.