Allow hot-reloading of the bridge logger (#1704)

* Allow logging to be hot-reloaded * changelog
matrix-org · Apr 27, 2023 · a750678 · a750678
1 parent 22c5e36
commit a750678
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/changelog.d/1704.feature b/changelog.d/1704.feature
@@ -0,0 +1 @@
+Bridge logging can now be hot-reloaded.
diff --git a/config.sample.yaml b/config.sample.yaml
@@ -466,7 +466,6 @@ ircService:
 
   # Configuration for logging. Optional. Default: console debug level logging
   # only.
-  # This key CANNOT be hot-reloaded
   logging:
     # Level to log on console/logfile. One of error|warn|info|debug
     level: "debug"

diff --git a/src/bridge/IrcBridge.ts b/src/bridge/IrcBridge.ts
@@ -54,6 +54,7 @@ import { RoomConfig } from "./RoomConfig";
 import { PrivacyProtection } from "../irc/PrivacyProtection";
 import { TestingOptions } from "../config/TestOpts";
 import { MatrixBanSync } from "./MatrixBanSync";
+import { configure } from "../logging";
 import { IrcPoolClient } from "../pool-service/IrcPoolClient";
 
 const log = getLogger("IrcBridge");
@@ -279,6 +280,8 @@ export class IrcBridge {
             !== JSON.stringify(newConfig.ircService.logging);
         if (hasLoggingChanged) {
             Logger.configure({ console: newConfig.ircService.logging.level });
+            configure(newConfig.ircService.logging);
+            this.config.ircService.logging = newConfig.ircService.logging;
         }
 
         const banSyncPromise = this.matrixBanSyncer?.syncRules(this.bridge.getIntent());