Automatically create mapped channels if mappings[...].createRoom is set
#1099
Conversation
| let exclusionQuerys = []; | ||
| console.log(server.getNetworkId(), server.getAutoCreateMappings()); | ||
| for (const mapping of server.getAutoCreateMappings()) { | ||
| exclusionQuerys.push(mapping.channel); |
There was a problem hiding this comment.
Even though this comes from a config that only an admin can configure, I wish we would escape the channel names before putting them into an SQL statement.
| createRoom: true, | ||
| }; | ||
|
|
||
| await test.beforeEach(env); |
There was a problem hiding this comment.
What is this?
... Looks up env-bundle...
| for (const [channel, data] of Object.entries(serverConfig.mappings)) { | ||
| if (data.createRoom) { | ||
| // We don't want to map this. | ||
| return; |
There was a problem hiding this comment.
I have a habit of mixing those up 😆
There was a problem hiding this comment.
.map and functions let you use your preferred return command. 😀
There was a problem hiding this comment.
| return; | |
| continue; |
|
|
||
| for (const [channel, opts] of Object.entries(serverConfig.mappings)) { | ||
| if (opts.createRoom) { | ||
| return; |
There was a problem hiding this comment.
One opts.createRoom makes the entire setting of the server impossible?
| }); | ||
| const notChannels = server.getAutoCreateMappings().map((c) => c.channel); | ||
| entries = (await entries).filter((e) => e.remote?.get("domain") === server.domain && | ||
| !notChannels.includes(e.remote?.get("channel") as string)); |
There was a problem hiding this comment.
remote? but a cast to string.
That seems like a cast where we're possibly lying to get TypeScript happy. Can this not be string or undefined?
| }); | ||
| const notChannels = server.getAutoCreateMappings().map((c) => c.channel); | ||
| entries = (await entries).filter((e) => e.remote?.get("domain") === server.domain && |
There was a problem hiding this comment.
entries was already awaited two lines above.
| for (const [channel, data] of Object.entries(serverConfig.mappings)) { | ||
| if (data.createRoom) { | ||
| // We don't want to map this. | ||
| return; |
There was a problem hiding this comment.
.map and functions let you use your preferred return command. 😀
Fixes #1096
The idea behind this is that you can just specify a bunch of mappings in your config and have rooms be created on the fly for them.
There are a few problems though. The behavior of
mappingsis to normally only bridge things defined in the section. If you remove a mapping entry, the bridge should stop bridging it. However this is more difficult in this case as the roomId is created by the bridge and not stored in the config. We need to persist it in the db, but this means adding special behaviors. I've done this for postgres, but it's harder to do in NeDB.