Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure QUIT messages are sent in pooling configuration #1752

Merged
merged 8 commits into from
Jul 27, 2023
Merged

Ensure QUIT messages are sent in pooling configuration #1752

merged 8 commits into from
Jul 27, 2023

Conversation

Half-Shot
Copy link
Contributor

Failing to specify a readyState means we missed this one.

@Half-Shot Half-Shot requested a review from a team as a code owner July 25, 2023 10:50
tadzik
tadzik approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@tadzik tadzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nitpicks.

spec/e2e/quit.spec.ts Outdated Show resolved Hide resolved
src/pool-service/RedisIrcConnection.ts Outdated Show resolved Hide resolved
@Half-Shot Half-Shot merged commit 8ec735f into develop Jul 27, 2023
15 checks passed
@Half-Shot Half-Shot deleted the hs/fix-quit-messages branch July 27, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadzik tadzik tadzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Half-Shot @tadzik